Fragment model #253
Open
Fragment model #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvanbasten-ns
requested review from
jpprins1
and removed request for
caspervdw
jpprins1
approved these changes
Dec 18, 2024
| @@ -115,6 +116,12 @@ def lines(self): | |||
| self.datasource_class(self.h5py_file, "lines"), **self._grid_kwargs | |||
| ) | |||
|
|
|||
| @property | |||
There was a problem hiding this comment.
Wat gebeurd hier als je een oude gridadmin pakt zonder 'fragments' ? Moet er nog een check in dat het bestaat of vangen we dat al ergens af..
There was a problem hiding this comment.
Goeie, hier zal ik een testje voor toevoegen.
There was a problem hiding this comment.
welke test valideert dat fragments aanroepen op een gewone gridadmin geen error geeft?
| @@ -508,6 +508,20 @@ def export_pumps(self): | |||
| dest, indent=self._indent | |||
| ) | |||
|
|
|||
| def export_fragments(self): | |||
There was a problem hiding this comment.
Moeten fragments (uiteindelijk) ook als geojson in de API terecht komen? Nb. kan prima als een follow-up,
| @@ -508,6 +508,20 @@ def export_pumps(self): | |||
| dest, indent=self._indent | |||
| ) | |||
|
|
|||
| def export_fragments(self): | |||
| if not self.ga.fragments.id.size == 0: | |||
There was a problem hiding this comment.
als de gridadmin geen fragments geeft dan hebben ze ook geen id. Dus ga.fragments.id gaat dan mis denk ik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Fragments to the model, including some implementation to the exporters to deal with polygons.
#254